Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean dumper #132

Merged
merged 2 commits into from Nov 28, 2021
Merged

Clean dumper #132

merged 2 commits into from Nov 28, 2021

Conversation

evgeniy-r
Copy link
Member

@evgeniy-r evgeniy-r commented Nov 10, 2021

✓ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features).

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #132 (105fc50) into main (81dd504) will decrease coverage by 3.33%.
The diff coverage is 72.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   88.62%   85.29%   -3.34%     
==========================================
  Files          52       52              
  Lines        3192     3217      +25     
==========================================
- Hits         2829     2744      -85     
- Misses        363      473     +110     
Impacted Files Coverage Δ
cli/pg_datanymizer/src/app.rs 44.61% <0.00%> (-5.39%) ⬇️
datanymizer_dumper/src/postgres/table.rs 95.36% <ø> (ø)
datanymizer_dumper/src/postgres/dumper.rs 36.72% <66.66%> (-51.36%) ⬇️
datanymizer_dumper/src/indicator.rs 100.00% <100.00%> (ø)
datanymizer_dumper/src/lib.rs 58.82% <100.00%> (-38.24%) ⬇️
...atanymizer_dumper/src/postgres/schema_inspector.rs 88.40% <100.00%> (-1.45%) ⬇️
datanymizer_dumper/src/postgres/query_wrapper.rs 28.57% <0.00%> (-19.05%) ⬇️
datanymizer_engine/src/settings/mod.rs 91.42% <0.00%> (-6.67%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81dd504...105fc50. Read the comment docs.

@evgeniy-r evgeniy-r force-pushed the simplify_settings branch 2 times, most recently from 4255138 to 19643f7 Compare November 28, 2021 16:07
Base automatically changed from simplify_settings to main November 28, 2021 16:28
@evgeniy-r evgeniy-r marked this pull request as ready for review November 28, 2021 17:06
@evgeniy-r evgeniy-r merged commit e066bac into main Nov 28, 2021
@evgeniy-r evgeniy-r deleted the clean_dumper branch November 28, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants