Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPY handle no fields #147

Merged
merged 4 commits into from Feb 5, 2022
Merged

Conversation

mbeynon
Copy link
Contributor

@mbeynon mbeynon commented Feb 3, 2022

✓ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

See issue #146 for more information

@evgeniy-r
Copy link
Member

Hello!

Thank you for your contribution!
Could you please fix the rustfmt/clippy warnings?
And also add unit tests and update CHANGELOG.md?

May I ask you to attach your database schema (without data) or at least the related part?

@evgeniy-r evgeniy-r linked an issue Feb 4, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #147 (a44dafa) into main (8d531f3) will increase coverage by 0.04%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   85.94%   85.99%   +0.04%     
==========================================
  Files          52       52              
  Lines        3187     3205      +18     
==========================================
+ Hits         2739     2756      +17     
- Misses        448      449       +1     
Impacted Files Coverage Δ
datanymizer_dumper/src/postgres/table.rs 95.31% <95.83%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d531f3...a44dafa. Read the comment docs.

@mbeynon
Copy link
Contributor Author

mbeynon commented Feb 5, 2022

Example schema.dump and config (test1.yaml) that shows the problem with schema_3.table_3_1 that has no fields

schema.dump.txt
test1.yaml.txt

@mbeynon
Copy link
Contributor Author

mbeynon commented Feb 5, 2022

The PR is now ready to merge

@evgeniy-r evgeniy-r merged commit 7d99bc2 into datanymizer:main Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed query when table has no defined fields
3 participants