pg_namespace to disambiguate repeated field name #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the TABLE_COLUMNS_QUERY to work as intended, but using pg_catalog.pg_namespace to disambiguate a case where the same name is used for a custom enum type in more than one schema (namespace) in the database.
Unfixed, this can result in
pg_datanymizer
building a list of columns with duplicate column names each time the name appears across all the namespaces. The COPY command is rejected by postgres, and the run is aborted.See issue #148 for more details.
Testable example: (enum
event_type
defined in 3 namespaces)schema.dump.txt
test2.yaml.txt
✓ Checklist: