Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to datanymizer #184

Merged
merged 3 commits into from Jul 14, 2022
Merged

Add logging to datanymizer #184

merged 3 commits into from Jul 14, 2022

Conversation

akirill0v
Copy link
Member

@akirill0v akirill0v commented Jul 14, 2022

✓ Checklist:

  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated (for bug fixes / features).

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #184 (31f3a80) into main (24115d7) will decrease coverage by 0.29%.
The diff coverage is 35.00%.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   86.88%   86.58%   -0.30%     
==========================================
  Files          57       57              
  Lines        4002     4010       +8     
==========================================
- Hits         3477     3472       -5     
- Misses        525      538      +13     
Impacted Files Coverage Δ
cli/pg_datanymizer/src/main.rs 7.69% <0.00%> (-8.98%) ⬇️
datanymizer_dumper/src/postgres/dumper.rs 31.39% <0.00%> (-0.75%) ⬇️
...atanymizer_engine/src/transformers/template/mod.rs 97.26% <80.00%> (-0.25%) ⬇️
cli/pg_datanymizer/src/options.rs 95.08% <100.00%> (+0.12%) ⬆️
...atanymizer_dumper/src/postgres/schema_inspector.rs 88.67% <0.00%> (-1.89%) ⬇️
...ngine/src/transformers/template/store_functions.rs 85.71% <0.00%> (-0.65%) ⬇️
...mizer_engine/src/transformers/phone/transformer.rs 80.43% <0.00%> (-0.42%) ⬇️
datanymizer_dumper/src/lib.rs 76.49% <0.00%> (-0.11%) ⬇️
datanymizer_dumper/src/postgres/table.rs 91.92% <0.00%> (-0.08%) ⬇️
datanymizer_engine/src/transformers/capitalize.rs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24115d7...31f3a80. Read the comment docs.

@@ -97,7 +98,13 @@ impl<W: 'static + Write + Send, I: 'static + Indicator + Send> PgDumper<W, I> {
self.indicator.inc_pb(1);

let row = PgRow::from_string_row(line?, table.clone());
let transformed = row.transform(&self.engine, cfg.name.as_str())?;
// let transformed = row.transform(&self.engine, cfg.name.as_str())?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, delete this row?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'll do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants