Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIS Login tests #743

Merged
merged 11 commits into from
Mar 21, 2020
Merged

Conversation

tboggiano
Copy link
Collaborator

A New PR

THANK YOU - We love to get PR's and really appreciate your time and help to improve this module

Accepting a PR

Before we accept the PR - please confirm that you have run the tests locally to avoid our automated build and release process failing. You can see how to do that in our wiki

https://github.com/sqlcollaborative/dbachecks/wiki

Please confirm you have 0 failing Pester Tests

[X] There are 0 failing Pester tests

Changes this PR brings

  • CIS Check Ensure 'CHECK_POLICY' Option is set to 'ON' for All SQL Authenticated Logins
  • CIS CHeck Ensure 'CHECK_EXPIRATION' Option is set to 'ON' for All SQL Authenticated Logins Within the Sysadmin Role
  • CIS Check Ensure 'MUST_CHANGE' Option is set to 'ON' for All SQL Authenticated Logins for new logins
  • Cleaned up two tests two user @().count instead of if for $nulls, much cleaner, BuiltIn Admin and SAExist

Please add below the changes that this PR covers. It doesnt need an essay just the bullet points :-)

@tboggiano
Copy link
Collaborator Author

Close 671
Close 670
Close 669

@tboggiano
Copy link
Collaborator Author

Ignore the fact I edited the workspace file and accidently checked it in. I thought it would cool to have the PSScriptAnalyzer stuff in my other dba* projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants