Return more SMO properties for Get-DbaLogin

[tboggiano]

Summary of new feature

There are some properties that would make writing a dbacheck for CIS easier and would be useful for users for dbatools as well that can be returned using SMO. I noticed issue #5732 as well, which I could combine into this as well if if were OK.

• Clear/concise description of what the problem is that the new feature can solve.
  Would like to add from SMO:

• MustChangePassword - Issue CIS Check Ensure 'MUST_CHANGE' Option is set to 'ON' for All SQL Authenticated Logins dbachecks#669 on dbachecks
• PasswordExpirationEnabled - Issue CIS CHeck Ensure 'CHECK_EXPIRATION' Option is set to 'ON' for All SQL Authenticated Logins Within the Sysadmin Role dbachecks#670 on dbachecks
• PasswordPolicyEnforced - Issue CIS Check Ensure 'CHECK_POLICY' Option is set to 'ON' for All SQL Authenticated Logins dbachecks#671 on dbachekcs

Proposed technical details (if applicable)

• e.g. Blog post reference that shows example code or functionality

Latest version of dbatools as of writing

• Please provide the latest released version of dbatools module.
  1.0.88

[wsmelton]

I'm ok with this but would be best to go ahead and add a format file I think this is one that would be good to force table output too.

[tboggiano]

What is a format file, or just point me to module that is using one for an example?

[wsmelton]

Actually never mind just forgot we use that Select-DefaultView instead of formatting files. #5732 was already handled in a PR, no one went back and closed it though.

The properties you noted are already available via the function. The exception would be MustChangePassword itself does not exists in SMO, that has to be grabbed via LOGINPROPERTY which is what got added in that PR. So it is IsMustChange.

We just don't return these on the default output, but this will still provide you those properties:

Get-DbaLogin ... | Select-Object IsMustChange, PasswordExpirationEnabled, PasswordPolicyEnforced

[tboggiano]

I noticed the properties were there once I downloaded the code to work on it, but the -Detailed switch doesn't work to return the values. So I'll check in code to fix that minor problem.

[tboggiano]

Well never mind I guess that is for people to provide what fields that one the same you just gave me I'll juts close this. Thanks.