Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect-DbaInstance - Support making DAC connection #6831

Closed
wsmelton opened this issue Sep 11, 2020 · 8 comments · Fixed by #7644
Closed

Connect-DbaInstance - Support making DAC connection #6831

wsmelton opened this issue Sep 11, 2020 · 8 comments · Fixed by #7644
Assignees
Labels
feature pending team feedback Waiting for feedback from other maintainers/contributors

Comments

@wsmelton
Copy link
Member

wsmelton commented Sep 11, 2020

Something I think @FriedrichWeinmann will need to assist with is allowing our DbaInstance parameter to handle admin:$instance so we can allow our connect command to make the DAC connection into SQL Server.

Currently, our type is borking because it can't parse it:

image

Once that is done then we can easily adjust the settings for the connection to handle making that DAC connection to the instance. Some of the leg work for this is being done via #6828

@FriedrichWeinmann
Copy link
Member

Happy to update that.
How exactly should I parse that notation however?

Is that <hostname>:<Instancename> ?

@wsmelton
Copy link
Member Author

The "admin:" I would think should indicator that the fact connection is desired. I don't know if we maybe add a property for this?

Anything after that would be your normal host and/or instance name.

@FriedrichWeinmann
Copy link
Member

Alright, so basically I'll be parsing everything after the colon as the actual input and the leading 'admin:' changes the input-type to 'DAC' or somesuch, which Connect-DbaInstance will respect?
Can definitely do that :)
Today.

@potatoqualitee
Copy link
Member

Thanks so much to you both 🥳

@wsmelton
Copy link
Member Author

Well they are exceptions that what is on the left on the colon is used.

"tcp:" vs "np:" whitch I think is being handled either on the type or by connect command, can't remember.

@potatoqualitee
Copy link
Member

(lol you made your theme sparkle, nice, @wsmelton !)

@andreasjordan
Copy link
Contributor

@FriedrichWeinmann - Is this already implemented?

@wsmelton
Copy link
Member Author

No, requires a change to our library code.

@andreasjordan andreasjordan added this to To do in AndreasJordan May 20, 2021
@andreasjordan andreasjordan moved this from To do to Waiting in AndreasJordan May 20, 2021
@andreasjordan andreasjordan added the pending team feedback Waiting for feedback from other maintainers/contributors label May 25, 2021
@andreasjordan andreasjordan moved this from Waiting to Connect-DbaInstance in AndreasJordan Jul 2, 2021
AndreasJordan automation moved this from Connect-DbaInstance to Done Jul 29, 2021
@andreasjordan andreasjordan removed this from Done in AndreasJordan Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature pending team feedback Waiting for feedback from other maintainers/contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants