-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect-DbaInstance - Support making DAC connection #6831
Comments
Happy to update that. Is that |
The "admin:" I would think should indicator that the fact connection is desired. I don't know if we maybe add a property for this? Anything after that would be your normal host and/or instance name. |
Alright, so basically I'll be parsing everything after the colon as the actual input and the leading 'admin:' changes the input-type to 'DAC' or somesuch, which Connect-DbaInstance will respect? |
Thanks so much to you both 🥳 |
Well they are exceptions that what is on the left on the colon is used. "tcp:" vs "np:" whitch I think is being handled either on the type or by connect command, can't remember. |
(lol you made your theme sparkle, nice, @wsmelton !) |
@FriedrichWeinmann - Is this already implemented? |
No, requires a change to our library code. |
Something I think @FriedrichWeinmann will need to assist with is allowing our
DbaInstance
parameter to handleadmin:$instance
so we can allow our connect command to make the DAC connection into SQL Server.Currently, our type is borking because it can't parse it:
Once that is done then we can easily adjust the settings for the connection to handle making that DAC connection to the instance. Some of the leg work for this is being done via #6828
The text was updated successfully, but these errors were encountered: