Fix/empty attribute #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__init__ method did not initialize empty attribute correctly leading to errors when using the dask datastructure. This commit fixes this and adds corresponding tests.
if data.nnz == 0 doesn't mean the array is empty it could be an array of purely zeros. replaced this check with a check for zero dimension which clearly indicates an empty frame.
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=========================================
- Coverage 82.58% 81.7% -0.88%
=========================================
Files 6 6
Lines 620 623 +3
=========================================
- Hits 512 509 -3
- Misses 108 114 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.