Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/empty attribute #13

Merged
merged 2 commits into from
Jul 11, 2017
Merged

Fix/empty attribute #13

merged 2 commits into from
Jul 11, 2017

Commits on Jul 11, 2017

  1. Fix empty attribute of sparsity.SparseFrame 

    __init__ method did not initialize empty attribute correctly leading to errors when using the dask datastructure. This commit fixes this and adds corresponding tests.
    @kayibal
    kayibal committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    b0411e6 View commit details
    Browse the repository at this point in the history

  2. Adjust _is_empty method. 

    if data.nnz == 0 doesn't mean the array is empty it could be an array of purely zeros. replaced this check with a check for zero dimension which clearly indicates an empty frame.
    @kayibal
    kayibal committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    8112b90 View commit details
    Browse the repository at this point in the history