Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO 3166-1 numeric contains invalid values #47

Closed
jheeffer opened this issue Nov 14, 2016 · 2 comments
Closed

ISO 3166-1 numeric contains invalid values #47

jheeffer opened this issue Nov 14, 2016 · 2 comments

Comments

@jheeffer
Copy link

jheeffer commented Nov 14, 2016

Hi,

The values in the ISO3166-1-numeric column are actually UN M49 codes (which is where you scrape them from).
These two code lists overlap almost completely, except for the two top ones. Channel Islands and Sark, are not in the ISO 3166-1 standard, but are in UN M49. So maybe it's good to either remove the top ones or change the column name & description.

@ewheeler
Copy link
Contributor

ewheeler commented Dec 1, 2016

Thanks @jheeffer !
Great catch. I had seen UN M49 and ISO 3166-1 described as synonymous but that's not the case.
I've updated the column and description. Since UN M49 is more-or-less a superset of ISO 3166-1, it is probably the more useful version to include (until I find a reliable source to scrape ISO 3166-1 so that it can also be included)
Thanks again!

@ewheeler ewheeler closed this as completed Dec 1, 2016
@hozn
Copy link
Contributor

hozn commented Dec 12, 2016

... But now the CSV can't be loaded, since the CSV column name wasn't updated ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants