Fix prepared queries #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Prepared` result responses get put into a prepared cache and when an `Unprepared` error response happen the cache is referenced to prepare the query on the erred node and the original request is re-tried.
|
Resolves #14 |
mpenick
commented
Sep 2, 2021
dougwettlaufer
approved these changes
Sep 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing code execute queries were just a pass-through. That means that if an unprepared error occurred it was just passed back to the driver. The problem is that an attempt to prepare that query again would be forwarded to a connection that was not the one that originally serviced the execute. This could cause a scenario where execute requests would never resolve from the unprepared state.
The proxy fixes this by keeping its own cache and properly handling unprepared errors. This cache was push down into the
proxycorebecause eventually we should add pre-preparing queries on add/up node events. This should be address in a follow up issue: #32