Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support k8s pods having multiple IPs #145

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Support k8s pods having multiple IPs #145

merged 1 commit into from
Nov 3, 2022

Conversation

michaelsembwever
Copy link
Member

No description provided.

@michaelsembwever
Copy link
Member Author

i think this might have addressed your previous problem @ossarga where you have to discover each pod explicitly.

@michaelsembwever michaelsembwever mentioned this pull request Jun 23, 2022
Merged
@michaelsembwever
Copy link
Member Author

@mieslep , do you see any value in this PR ? (while it won't address the internal IPs being used, maybe it addresses other issues…)

mieslep
mieslep approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@mieslep mieslep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is more resilient yes.

@michaelsembwever michaelsembwever merged commit 79afee7 into master Nov 3, 2022
@michaelsembwever michaelsembwever deleted the mck/k8s-support-multiple-podIPs branch January 28, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mieslep mieslep mieslep approved these changes

@anthony-grasso-datastax anthony-grasso-datastax Awaiting requested review from anthony-grasso-datastax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsembwever @mieslep