Fix private-link endpoint registration #41
Conversation
- Update terraform sdk - Remove datacenter ID validation - Fix call to setPrivateLinkEndpointData
| @@ -23,7 +23,7 @@ func TestDataSourceAccessListEndpoints(t *testing.T){ | |||
| func testAccPrivateAccessListDataSource() string { | |||
| return fmt.Sprintf(` | |||
| data "astra_access_list" "dev" { | |||
| database_id = "8d356587-73b3-430a-9c0e-d780332e2afb" | |||
| database_id = "aba3cf20-d579-4091-a36d-9c9f75096031" | |||
There was a problem hiding this comment.
What account/org are these new IDs from? Something that we can reliably share down the road, I guess perhaps until we make the changes we talked about where for tests we'd re-create the database each time so we don't have these hard coded IDs running around anyhow?
There was a problem hiding this comment.
These UUIDs are just the ids for the Astra Database I created in my Astra account. Going forward, these need to change so that the database is created for the test run, and then cleaned up after.
| endpoint_id = "vpce-04cf066a99d812a8d" | ||
| database_id = "aba3cf20-d579-4091-a36d-9c9f75096031" | ||
| datacenter_id = "aba3cf20-d579-4091-a36d-9c9f75096031-1" | ||
| endpoint_id = "vpc-5fbb2e34" |
There was a problem hiding this comment.
Similar question here about the hard coded IDs, in this case is this the AWS ID or an ID related to Astra?
There was a problem hiding this comment.
Yep. In fact, the endpoint_id is probably wrong here. I have a VPC id, not an endpoint ID. But again, it's a resource in AWS this time. I need to check and see if this endpoint needs to exist ahead of the test, or if it can be inferred during the test.
Fixes #32