Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Implement key encoding of entity for key-value store #120

Closed
Tracked by #50
yuqi1129 opened this issue Jul 25, 2023 · 1 comment · Fixed by #160
Closed
Tracked by #50

[Subtask] Implement key encoding of entity for key-value store #120

yuqi1129 opened this issue Jul 25, 2023 · 1 comment · Fixed by #160
Assignees
@yuqi1129
Milestone
Graviton v0.1.0 (...

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jul 25, 2023 •
edited

Describe the subtask

This issue is a subtask for #50

Description

This issue will do the detailed implementation for entity encoding in the Key-Value store, more precisely It aims to implement the interface EntityKeyEncoder

Parent issue

#50
@yuqi1129 yuqi1129 self-assigned this Jul 25, 2023
This was referenced Jul 25, 2023
Closed
Closed
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Jul 25, 2023
@yuqi1129
Copy link
Contributor Author

Here is the schema, https://docs.google.com/document/d/1jyXqIoiS8sBOCv8hhvkm2Ln9gkTnWqpCgpqhaAUboFQ/edit#heading=h.uueph4t49qwd

@yuqi1129 yuqi1129 mentioned this issue Aug 2, 2023
Merged
jerryshao pushed a commit that referenced this issue Aug 8, 2023
@yuqi1129
[#120] feat(core): Implement key encoding of entity for key-value sto…
5d8f778 
…re (#160)

### What changes were proposed in this pull request?

In this PR, We introduce a detailed key encoding method for key-value
store, please see
https://docs.google.com/document/d/1jyXqIoiS8sBOCv8hhvkm2Ln9gkTnWqpCgpqhaAUboFQ/edit
for more information

### Why are the changes needed?

1. More detailed implementation for `CustomEntityKeyEncoder`

Fix: #120 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

New UT `TestEntityKeyEncoding` was added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
None yet
Projects
None yet
Milestone
Graviton v0.1.0 (updated)
Development

Successfully merging a pull request may close this issue.

[#120] feat(core): Implement key encoding of entity for key-value store yuqi1129/graviton
2 participants
@jerryshao @yuqi1129