Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clarify that the stateRoot is required for simplehash verificati… #565

Merged
merged 2 commits into from
Jun 9, 2023
Merged

fix: clarify that the stateRoot is required for simplehash verificati… #565

merged 2 commits into from
Jun 9, 2023

Conversation

robinbryce
Copy link
Contributor

@robinbryce robinbryce commented Jun 9, 2023 •
edited by ghost

…on while the privateStateRoot is required for khipu

Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@robinbryce
fix: clarify that the stateRoot is required for simplehash verificati…
19f7c9e 
…on while the privateStateRoot is required for khipu
@robinbryce
fix: clarify that the stateRoot is required for simplehash verificati…
d86a5d0 
…on while the privateStateRoot is required for khipu
JAG-UK
JAG-UK approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robinbryce robinbryce merged commit f49c1f7 into main Jun 9, 2023
1 check passed
@SteveLasker SteveLasker deleted the robin/8042-simplehash-verify-with-stateroot branch July 18, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAG-UK JAG-UK JAG-UK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robinbryce @JAG-UK