Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old version of SCITT Receipts #729

Closed
wants to merge 1 commit into from

Conversation

SteveLasker
Copy link
Contributor

This was a previous version of SCITT Receipts that is not consistent with the current SCITT Receipt format.

Signed-off-by: steve lasker <stevenlasker@hotmail.com>
robinbryce
robinbryce previously approved these changes Dec 8, 2023
Copy link
Contributor

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to ensure the bit about checking the receipt against the ledger is included else where. The SCITT material that is specifically about the datatrails TS should include this I think

https://app.datatrails.ai/archivist/v1/notary/receipts \
| jq -r .receipt)
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have this verification process documented somewhere else now ? Particularly the bit about verifying the receipt against our private ledger. We do need that documented somewhere. The counter signature on its own is not enough

@robinbryce robinbryce self-requested a review December 8, 2023 11:07
@robinbryce robinbryce dismissed their stale review December 8, 2023 11:09

in advertently approved

Copy link
Contributor

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments re the verification. this delete is fine, but only if we preserve the verification of receipts against the ledger elsewhere. Particularly, we do need to show that in the datatrails specifics of receipt verification

@SteveLasker
Copy link
Contributor Author

closing as we'll archive under #732

@SteveLasker SteveLasker deleted the steve/remove-old-receipt branch July 18, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants