Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support python 3.12 #14

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Support python 3.12 #14

merged 1 commit into from
Nov 3, 2023

Conversation

eccles
Copy link
Contributor

@eccles eccles commented Oct 18, 2023 •
edited by ghost
Loading

Upgrade pylint to 3.0 and other tools
Add support for python 3.12

Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

Support python 3.12
553fb7c 
Upgrade pylint to 3.0 and other tools
Add support for python 3.12
pcnorth
pcnorth reviewed Oct 20, 2023
View reviewed changes
Copy link

@pcnorth pcnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me but I don't really know what the changes to requirements-dev.txt mean. The purpose of the other changes are obvious.
Happy to approve it without fully understanding if the PR is just a formality.

pcnorth
pcnorth approved these changes Nov 3, 2023
View reviewed changes
Copy link

@pcnorth pcnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paul confirmed that it is ok to approve this.

@eccles eccles merged commit 440fd68 into main Nov 3, 2023
10 checks passed
@eccles eccles deleted the dev/eccles/python-3.12 branch November 3, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcnorth pcnorth pcnorth approved these changes

@robinbryce robinbryce Awaiting requested review from robinbryce

@JAG-UK JAG-UK Awaiting requested review from JAG-UK

@honourfish honourfish Awaiting requested review from honourfish

@mmwilder26 mmwilder26 Awaiting requested review from mmwilder26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eccles @pcnorth