Fixing column chart axis label rounding errors #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t'll be in https://github.com/washingtonpost/datawrapper) datawrapper fork, that addresses rounding errors on column chart axes. There's some inconsistency between how column chart and grouped-column chart is structred, looking at the `horzGrid` is just one example (compare how `theme` is defined), `__gridlabels` vs `tickLabels`, etc.) The fundamental challenge here was parsing out when `formatValue` in dw.js/src/dw.chart.js was used (which accepts a boolean rounding arg), and when `formatValue` defined in the plug was used (which just overrides the former func and replaces it with `columnFormatter` in `/dw.js/dw-2.0.js`)
gka
pushed a commit
that referenced
this pull request
Sep 13, 2021
gka
pushed a commit
that referenced
this pull request
Sep 26, 2021
* use IconDisplay in IconButton, new style, docs & storybook * install latest @datawrapper/icons * lint * set asset url Co-authored-by: David Kokkelink <david@datawrapper.de>
gka
pushed a commit
that referenced
this pull request
Dec 5, 2021
* use IconDisplay in IconButton, new style, docs & storybook * install latest @datawrapper/icons * lint * set asset url Co-authored-by: David Kokkelink <david@datawrapper.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change we made in the soon-to-be-open sourced (the next few days, it'll be in https://github.com/washingtonpost/datawrapper) datawrapper fork, that addresses rounding errors on column chart axes.
There's some inconsistency between how column chart and grouped-column chart
is structred, looking at the
horzGridis just one example (compare howthemeis defined),__gridlabelsvstickLabels, etc.)The fundamental challenge here was parsing out when
formatValuein dw.js/src/dw.chart.js was used (which accepts a boolean rounding arg), and whenformatValuedefined in the plug was used (which just overrides the former func and replaces it withcolumnFormatterin/dw.js/dw-2.0.js)