Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use node API for chart editing #267

Merged
merged 1 commit into from Mar 25, 2020
Merged

feat: use node API for chart editing #267

merged 1 commit into from Mar 25, 2020

Conversation

sto3psl
Copy link
Contributor

@sto3psl sto3psl commented Nov 25, 2019

With the the official release of the Node API, I thought it would be fun to put it under a lot of load immediately 馃槄.

Chart editing now sends data to the new API. Please thoroughly test this and check if any anomalies happen. 鉁岋笍

If you want to test locally, you need to have the Node API setup and running. If you are not on the Docker setup, talk to me. If you are using Docker, talk to @gka or @davidkokkelink.

@davidkokkelink
Copy link
Member

thanks. FYI: charts that use svelte controls save through this function: https://github.com/datawrapper/shared/blob/master/chart.js#L16-L18

to test it, you'll need to change it there and rebuild the respective charts

@sto3psl sto3psl mentioned this pull request Nov 25, 2019
Merged
@sto3psl
Copy link
Contributor Author

sto3psl commented Nov 25, 2019

After installing the new shared version, a whole bunch of stuff changed. Looked like some static files where not minified. Is all of that fine? Do I need to remove changes?

@sto3psl
Copy link
Contributor Author

sto3psl commented Nov 25, 2019

Am I assuming correct, that visualization plugins need to update their @datawrapper/shared versions too?

@davidkokkelink
Copy link
Member

davidkokkelink commented Nov 25, 2019 •
edited

Am I assuming correct, that visualization plugins need to update their @datawrapper/shared versions too?

yes

@sto3psl
Copy link
Contributor Author

sto3psl commented Nov 25, 2019

Does anything speak against checking out this branch on staging, would like to test it there?

@gka
Copy link
Member

gka commented Nov 26, 2019

nope, testing this on staging is fine!

@gka
Copy link
Member

gka commented Mar 25, 2020

I think this has been tested enough now?

@gka
Copy link
Member

gka commented Mar 25, 2020

rebased to current master

@gka gka merged commit 8ab2d35 into master Mar 25, 2020
@gka gka deleted the node-editing branch March 25, 2020 12:23
gka pushed a commit that referenced this pull request Nov 28, 2021
@jakubdatawrapper
chore(libs): Direct import (#267)
d70d129 
* libs: Direct imports

* libs: Direct imports (simp-maps, ext-dat, vis-col)

* tables/test: Use chart-core/lib/ instead of dist/

* chart-core/gitignore: Unignore dist/

And remove boilerplate. This should be in the top-level .gitignore.

* chart-core/dist: Add to version control

* polyfills/gitignore: Unignore dist/

And remove boilerplate. This should be in the top-level .gitignore.

* polyfills/package-lock.json: Update

* chart-core/package-lock: Update

* external-data: Rebuild

* simple-maps: Rebuild

* polyfills/dist: Add to version control

* eslintignore,prettierignore: Ignore polyfills dist

And sort alphabetically.

* chart-core: Rebuild

* frontend: Install polyfills explicitly

* Update package-locks where package.json changed

* d3-lines: Rebuild

* d3-maps: Rebuild

* export-pdf: Rebuild

* locator-maps: Rebuild

* tables: Rebuild

* visualization-pie-chart: Rebuild

* visualization-pie-chart: Use global linter

* visualization-pie-chart: Format

* php/svelte: Rebuild

* visualization-pie-chart: Lint

* visualization-pie-chart: Rebuild

* tables: Rebuild

* d3-maps: Update .githead

* api: Update .githead

* github/services-php: Rename lint-and-test to lint

* github/libs-chart-core: Try npm v7

* github: Use npm v7 to install subdeps

* github/plugins-ext-data: Run npm ci in linked deps

* github/plugins-tables: Run npm ci in linked deps

* github/plugins-exp-pdf: Run npm ci in linked deps

* tests: Make svelte-loader ready for Node v16

* export-pdf: Upgrade opentype.js patch version

* export-pdf: Make pdfFonts ready for Node 16

* github: Manually install npm v7 with Node 14

Instead of using Node 15, for which the app is not ready.

* github: Don't build chart-core after npm i

* github/ext-data: Fix missing npm ci in plugin dir

* github/api,simple-maps: Try expl chart-core inst

* prettierignore: Remove duplicate line

* export-pdf: Rebuild

* tables: Rebuild
gka pushed a commit that referenced this pull request Dec 5, 2021
@jakubdatawrapper
chore(libs): Direct import (#267)
8181798 
* libs: Direct imports

* libs: Direct imports (simp-maps, ext-dat, vis-col)

* tables/test: Use chart-core/lib/ instead of dist/

* chart-core/gitignore: Unignore dist/

And remove boilerplate. This should be in the top-level .gitignore.

* chart-core/dist: Add to version control

* polyfills/gitignore: Unignore dist/

And remove boilerplate. This should be in the top-level .gitignore.

* polyfills/package-lock.json: Update

* chart-core/package-lock: Update

* external-data: Rebuild

* simple-maps: Rebuild

* polyfills/dist: Add to version control

* eslintignore,prettierignore: Ignore polyfills dist

And sort alphabetically.

* chart-core: Rebuild

* frontend: Install polyfills explicitly

* Update package-locks where package.json changed

* d3-lines: Rebuild

* d3-maps: Rebuild

* export-pdf: Rebuild

* locator-maps: Rebuild

* tables: Rebuild

* visualization-pie-chart: Rebuild

* visualization-pie-chart: Use global linter

* visualization-pie-chart: Format

* php/svelte: Rebuild

* visualization-pie-chart: Lint

* visualization-pie-chart: Rebuild

* tables: Rebuild

* d3-maps: Update .githead

* api: Update .githead

* github/services-php: Rename lint-and-test to lint

* github/libs-chart-core: Try npm v7

* github: Use npm v7 to install subdeps

* github/plugins-ext-data: Run npm ci in linked deps

* github/plugins-tables: Run npm ci in linked deps

* github/plugins-exp-pdf: Run npm ci in linked deps

* tests: Make svelte-loader ready for Node v16

* export-pdf: Upgrade opentype.js patch version

* export-pdf: Make pdfFonts ready for Node 16

* github: Manually install npm v7 with Node 14

Instead of using Node 15, for which the app is not ready.

* github: Don't build chart-core after npm i

* github/ext-data: Fix missing npm ci in plugin dir

* github/api,simple-maps: Try expl chart-core inst

* prettierignore: Remove duplicate line

* export-pdf: Rebuild

* tables: Rebuild
gka pushed a commit that referenced this pull request Apr 10, 2022
@jakubdatawrapper
chore(libs): Direct import (#267)
25ac8e4 
* libs: Direct imports

* libs: Direct imports (simp-maps, ext-dat, vis-col)

* tables/test: Use chart-core/lib/ instead of dist/

* chart-core/gitignore: Unignore dist/

And remove boilerplate. This should be in the top-level .gitignore.

* chart-core/dist: Add to version control

* polyfills/gitignore: Unignore dist/

And remove boilerplate. This should be in the top-level .gitignore.

* polyfills/package-lock.json: Update

* chart-core/package-lock: Update

* external-data: Rebuild

* simple-maps: Rebuild

* polyfills/dist: Add to version control

* eslintignore,prettierignore: Ignore polyfills dist

And sort alphabetically.

* chart-core: Rebuild

* frontend: Install polyfills explicitly

* Update package-locks where package.json changed

* d3-lines: Rebuild

* d3-maps: Rebuild

* export-pdf: Rebuild

* locator-maps: Rebuild

* tables: Rebuild

* visualization-pie-chart: Rebuild

* visualization-pie-chart: Use global linter

* visualization-pie-chart: Format

* php/svelte: Rebuild

* visualization-pie-chart: Lint

* visualization-pie-chart: Rebuild

* tables: Rebuild

* d3-maps: Update .githead

* api: Update .githead

* github/services-php: Rename lint-and-test to lint

* github/libs-chart-core: Try npm v7

* github: Use npm v7 to install subdeps

* github/plugins-ext-data: Run npm ci in linked deps

* github/plugins-tables: Run npm ci in linked deps

* github/plugins-exp-pdf: Run npm ci in linked deps

* tests: Make svelte-loader ready for Node v16

* export-pdf: Upgrade opentype.js patch version

* export-pdf: Make pdfFonts ready for Node 16

* github: Manually install npm v7 with Node 14

Instead of using Node 15, for which the app is not ready.

* github: Don't build chart-core after npm i

* github/ext-data: Fix missing npm ci in plugin dir

* github/api,simple-maps: Try expl chart-core inst

* prettierignore: Remove duplicate line

* export-pdf: Rebuild

* tables: Rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gka gka gka approved these changes

@ilokhov ilokhov Awaiting requested review from ilokhov

@davidkokkelink davidkokkelink Awaiting requested review from davidkokkelink

@elanals elanals Awaiting requested review from elanals

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@sto3psl @davidkokkelink @gka