feat!: use type-safe variant of Channel and ChannelNumber everywhere. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datdenkikniet
force-pushed
the
type-safe-channels
branch
4 times, most recently
from
ea9fbac
to
d344839
Compare
datdenkikniet
commented
Feb 10, 2024
There was a problem hiding this comment.
Think this was a bad merge: this file was duplicated, and removing it had no discernable effect. Still technically breaking because we had some items from it pub use'd
datdenkikniet
force-pushed
the
type-safe-channels
branch
2 times, most recently
from
ef8f16e
to
48feaa9
Compare
This deduplicates the places in which we may have (invalid) channel numbers Remove duplicate get_channel_authentication_capabilities.rs BREAKING CHANGE
datdenkikniet
force-pushed
the
type-safe-channels
branch
from
48feaa9
to
ff20b77
Compare
|
Thank you for the ping. On review it looks fine however I'm travelling currently and won't be able to test it integrated into our code for a few days. |
datdenkikniet
changed the title
|
I've tried this on a few boxes now and it's worked as expected everywhere. It's worth pointing out that none of the SDRs have a channel number other than 0 though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deduplicates the places in which we may have (invalid) channel numbers
Since this touches some of the edits you've made (though I am relatively certain I have gotten it right), would appreciate a quick look @richardstephens.