Allow parseJSON to accept strings without a trailing 'Z' symbold and with up to 6 digits in the milliseconds field (#1496)
#1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkozickis
requested changes
Oct 28, 2019
|
Thank you @dmytro-gokun. I think the big bad Oracle truncates milliseconds, so we can just follow the lead on this one. |
|
@dkozickis You are right. There is no real need to over-complicate this. If someone really cares about fractional milliseconds and rounding, they should probably do it server-side. |
dkozickis
requested changes
Oct 29, 2019
… with up to 6 digits in the milliseconds field (date-fns#1496)
dkozickis
approved these changes
Nov 2, 2019
|
Thank you @dmytro-gokun ! |
This was referenced Nov 25, 2019
This was referenced Feb 18, 2020
This was referenced Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's one thing to think about though.. JS Date does not allow to have fractional milliseconds. So, the way i've implemented it is that extra digits are simply truncated. E.g.:
2019-12-31T23:59:59.999999Z becomes 2019-12-31T23:59:59.999Z
The question arises: do we need implemented a proper rounding here instead of truncation? E.g., with proper rounding:
2019-12-31T23:59:59.999999Z becomes 2020-01-01T00:00:00Z
In my opinion, this is not really needed and we should keep truncating it for the sake of simplicity. But I'd like to hear different opinions.