Fix for timezones with minute Offsets >0 #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible by 60. For Indian Timezone +05:30 or 330 minutes the output becomes +5.5:30 but as per ISO 8601 standard it should be +05:30. hourOffset should be "05" and minute offset should be "30" but currently hourOffset is set to "5.5"
|
|
imballinst
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
ah, right! I completely missed the non-standard time zones. Thank you for fixing this!
|
Still not merged? |
kossnocorp
approved these changes
Feb 3, 2020
|
I found this PR only after also implementing the fix. If you want a test that actually tests the output to go with this, feel free to use: mtkopone@c0f4396 |
|
@mtkopone that's perfect, thank you a lot for this! |
|
I was overwhelmed lately, thank you for your patience! The fix was released with |
This was referenced Mar 12, 2020
This was referenced Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example Indian Standard Timezone IST (https://en.wikipedia.org/wiki/Indian_Standard_Time) +05:30 or 330 minutes the output becomes +5.5:30 but as per ISO 8601 standard it should be +05:30. hourOffset should be "05" and minute offset should be "30" but currently hourOffset is set to "5.5"