formatRFC3339: fix non standard time zones #1912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Try Ajitiono <ballinst@gmail.com>
Signed-off-by: Try Ajitiono <ballinst@gmail.com>
Signed-off-by: Try Ajitiono <ballinst@gmail.com>
|
Hi, it's duplicate of PR #1890 ;) |
|
@piotrl oh, apologies! I didn't check the list of PRs first. I'll assign you to that issue instead and close this one. Thanks for working on that PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1911. This PR floors the
hourOffsetinformatRFC3339, so for non-standard time zones, e.g. for IST, it becomes05:30instead of5.5:30.This fix is similar to #1599, with the addition of the
formatRFC3339test to thescripts/test/formatISO.sh. If the name of the file needs to be changed, e.g. toformat.sh(since it now contains both formatISO and formatRFC3339), please let me know!