add parseISODuration

[benjamincharity]

Adds a function to parse a string into a duration according to the ISO 8601 format

NOTE: This PR simply adds finishing touches to the awesome work already done by @wuzzeb here: #1947

[benjamincharity]

@kossnocorp

a) I noticed that when I ran the build script prior to creating my PR, it generated several files that seemed unrelated
b) yarn test passed locally prior to running the build script - possibly failure is due to point a?

Feel free to point me in the direction needed to fix these (this is my first dive into the date-fns repo as a contributor)

[kossnocorp]

Looks good. I cleaned up docs a bit and partially solved the issue with extra files.

[andystalick]

Could someone re-run these tests? Looks like there is a problem finding an example file.

[zb140]

I came here looking for a function like this, so I'm super excited to see that someone's working on one. One small comment though: the documentation and typings all say this will return null for these exceptional cases, but the actual code returns {}. I like null better, but either way they should match.

[benjamincharity]

Good callout. This is a doc that wasn't updated. I went with {} based on @kossnocorp 's suggestion. I'll get this update pushed today.

[benjamincharity]

@kossnocorp Whenever you get a chance, these workflows are ready to run again 👍

[Pickachu]

Howwdy 😄 , thanks for the progress made with this issue! I'm looking forward for the addtion to the of this function to the lib.

Taking a quick look at the source, I see no reference for the week descriptor (W)

date-fns/src/parseISODuration/index.js

Lines 3 to 6 in 30d610d

	var nr = '\\d+(?:[\\.,]\\d+)?'
	var dateRegex = '(' + nr + 'Y)?(' + nr + 'M)?(' + nr + 'D)?'
	var timeRegex = 'T(' + nr + 'H)?(' + nr + 'M)?(' + nr + 'S)?'
	var durationRegex = new RegExp('P' + dateRegex + '(?:' + timeRegex + ')?')

According Luxon specs metioned here and the standard, it seems that this value should be possible:

    check("P1W1DT13H23M34S", { weeks: 1, days: 1, hours: 13, minutes: 23, seconds: 34 });

Was this intentionally left out until the next version of this function?

[adrienharnay]

Hello, is this still blocked? What is needed to get it to the last mile?

[andystalick]

Thanks so much for approving the MR! We are real close, just need someone with permissions to resolve these conflicts. ❤️

[fturmel]

@benjamincharity need any help to finish this PR? I can pick it up if you want.

At the very least, conflicts should be resolved and the code should be converted to TypeScript.

[benjamincharity]

@fturmel feel free to pick this up. I’m a bit slammed at work currently.

[fturmel]

@benjamincharity I rebased and converted to TS, but if that's OK I'll need write permission to your branch so we can keep all the work here in the same PR. If not, let me know how you want to proceed.

I also found a bug and some opportunities to improve the PR, so I've put this in draft mode for now.

[benjamincharity]

@fturmel I've added you as a collaborator

[its-danny]

any updates on this?

[sslgeorge]

@fturmel can you please share more information about the bug you found, someone else could jump in and help if you are slammed with work.

[its-danny]

for anyone needing this, i've moved to using duration-fns for now and it works.

[davetapley]

Third attempt at getting this in! #3151