Add zh-CN locale #792
Merged
Add zh-CN locale #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
due to CI test job2 and job3 fail |
1 similar comment
|
due to CI test job2 and job3 fail |
|
due to CI test job2 fail |
leshakoss
reviewed
Jun 22, 2018
| } | ||
|
|
||
| // Note: in English, the names of days of the week and months are capitalized. |
There was a problem hiding this comment.
Please remove this comment
There was a problem hiding this comment.
ok, i will remove those comment
| return String(number) | ||
| var unit = String(options.unit) | ||
| var unitMap = { | ||
| year: ' 年', |
There was a problem hiding this comment.
Could you please explain what is happening here? Would it translate as "2018th year"?
There was a problem hiding this comment.
yes. it would translate as "2018th year", should i remove the unit ? just translate as "第2018" which means "2018th"
There was a problem hiding this comment.
@cubicwork yes, remove them please. While it could be useful, this behaviour is inconsistent with other locales
|
The locale is released as |
lc-soft
reviewed
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Simplified Chinese language support for date-fns v2.0