Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'LYNX B.V. Germany Branch' (community contribution) #2106

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add 'LYNX B.V. Germany Branch' (community contribution) #2106

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dfef7e
Add 'LYNX B.V. Germany Branch' (community contribution)
datenanfragen-community-edits Feb 14, 2023
79c29fd
Update using data editor
baltpeter Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 19 additions & 0 deletions companies/lynxbroker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"slug": "lynxbroker",
"relevant-countries": [
"de"
],
"categories": [
"finance"
],
"name": "LYNX B.V. Germany Branch",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (10117 Berlin) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin\nGermany",
Suggested change
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin\nDeutschland",
Suggested change
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin\nUnited States of America",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "LYNX B.V. Germany Branch\nZweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",
"address": "Zweigniederlassung Deutschland\nCharlottenstraße 68\n10117 Berlin",

"phone": "030-303286690",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "030-303286690"
}

"email": "service@lynxbroker.de",
"web": "https://www.lynxbroker.de/",
"sources": [
"https://www.lynxbroker.de/",
"https://github.com/datenanfragen/data/pull/2106"
],
"quality": "verified"
}