-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge verein-website into website #209
Conversation
The main change here is a new Markdown parser. We need to explicitly allow inline HTML. Also, the new parser apparently handles some cases differently, which is fun.
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
The menu is now deliberately hardcoded instead of using the Hugo menu feature. I genuinely can't see any advantage to that feature and without it, i18n is trivial here.
* The 'verein.datenanfragen.de' website is no longer active, it has been merged into the main website. * We have started a new language version at demandetesdonnees.fr.
For now, this only includes the NPM dependencies but this is much better than previously.
For now, this only includes the NPM dependencies but this is much better than previously.
@zner0L This is ready for review now. This needs to be merged first, followed by datenanfragen/verein-website#10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like all that very much! Thanks for taking on the challenge. I highlighted the things that I might want changed.
The problem was that we were copying the transfer details using `innerHTML` which obviously doesn't preserve the canvas data. Now, we are also repainting the QR codes in the print window. The print function was already specific to this use-case but it is now even more, so it doesn't make sense to keep it in `browser.js`, this commit moves it into the `DonationWidget.js`. Finally, keep the QR code background pure white in the print window as opposed to the slight off-white on the main site.
Note: Once this is merged, we should inform the ITZ of the new URL for the transparency page. |
No description provided.