Merge verein-website into website #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change here is a new Markdown parser. We need to explicitly allow inline HTML. Also, the new parser apparently handles some cases differently, which is fun.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
The menu is now deliberately hardcoded instead of using the Hugo menu feature. I genuinely can't see any advantage to that feature and without it, i18n is trivial here.
* The 'verein.datenanfragen.de' website is no longer active, it has been merged into the main website. * We have started a new language version at demandetesdonnees.fr.
For now, this only includes the NPM dependencies but this is much better than previously.
For now, this only includes the NPM dependencies but this is much better than previously.
baltpeter
changed the title
|
@zner0L This is ready for review now. This needs to be merged first, followed by datenanfragen/verein-website#10. |
zner0L
requested changes
Dec 9, 2019
zner0L
requested changes
Dec 9, 2019
The problem was that we were copying the transfer details using `innerHTML` which obviously doesn't preserve the canvas data. Now, we are also repainting the QR codes in the print window. The print function was already specific to this use-case but it is now even more, so it doesn't make sense to keep it in `browser.js`, this commit moves it into the `DonationWidget.js`. Finally, keep the QR code background pure white in the print window as opposed to the slight off-white on the main site.
|
Note: Once this is merged, we should inform the ITZ of the new URL for the transparency page. |
zner0L
approved these changes
Dec 10, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.