avoid deprecated utcfromtimestamp #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh dear, CI is not looking healthy |
Yeah that's always the problem with this project (and most of the other low-velocity projects I have). Every time I try to make a change the CI has broken out from under me and I have to spend the time I had budgeted to make the change on fixing the CI. |
|
Thanks! |
Dreamsorcerer
added a commit
to aio-libs/aiohttp
that referenced
this pull request
Aug 10, 2023
## What do these changes do? Ignore `dateutil` DeprecationWarning on Python 3.12. It's already fixed on upstream dateutil/dateutil#1285. Just waiting for a new release now. Requires #7503 --------- Co-authored-by: Sam Bull <git@sambull.org> Co-authored-by: Sam Bull <aa6bs0@sambull.org>
patchback bot
pushed a commit
to aio-libs/aiohttp
that referenced
this pull request
Aug 10, 2023
## What do these changes do? Ignore `dateutil` DeprecationWarning on Python 3.12. It's already fixed on upstream dateutil/dateutil#1285. Just waiting for a new release now. Requires #7503 --------- Co-authored-by: Sam Bull <git@sambull.org> Co-authored-by: Sam Bull <aa6bs0@sambull.org> (cherry picked from commit 40203b7)
Dreamsorcerer
pushed a commit
to aio-libs/aiohttp
that referenced
this pull request
Aug 10, 2023
…[3.12] (#7506) **This is a backport of PR #7505 as merged into master (40203b7).** ## What do these changes do? Ignore `dateutil` DeprecationWarning on Python 3.12. It's already fixed on upstream dateutil/dateutil#1285. Just waiting for a new release now. Requires #7503 Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
|
@pganssle Can you push a release with this change to PyPI please? |
13 tasks
|
I think the merged solution may be wrong. I think it should keep timezone-aware object, something like this: EPOCH = datetime.datetime.fromtimestamp(0, datetime.UTC)Edit: |
2 tasks
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1284