Drop support for Python 2.6 #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm amenable to this, but I'd like to get out at least one more bugfix release on timezone support before Python 2.6 is dropped. |
|
@jdufresne If you have time, can you rebase and update this PR? I think we can go ahead and merge. |
I would humbly like to suggest dateutil drop support for Python 2.6. The last release of Python 2.6 was 2013-10-29, over 3 years ago. It is no longer receiving security fixes. https://www.python.org/dev/peps/pep-0361/ The pip project itself has recently dropped support for 2.6. Their numbers estimate that Python 2.6 accounts for ~2% of their downloads. pypa/pip#4343 For projects that still use Python 2.6, they can continue to pip install an older version. I've tried my best to remove as much 2.6 specific code as I can, including the 'Programming Language :: Python :: 2.6' trove classifier from setup.py. I've also removed Travis CI testing, which should result in faster testing and fewer wasted resources. Code changed: - Removed Python2.6 from testing configuration - setup.py cleanups due to fewer version complications - Removed unittest2 dependency and monkey patching - Use set literals - Use dict comprehension - Remove total_seconds workaround - Remove TarFile.open() context manager workaround Thanks for considering.
|
Thanks @pganssle. I've rebased the changes on to the latest master. All additional feedback welcome. |
|
Thanks @jdufresne. So far it looks good but I'll give it a more thorough review and merge tonight. |
|
OK, LGTM! |
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would humbly like to suggest dateutil drop support for Python 2.6.
The last release of Python 2.6 was 2013-10-29, over 3 years ago. It is
no longer receiving security fixes.
https://www.python.org/dev/peps/pep-0361/
The pip project itself has recently dropped support for 2.6. Their
numbers estimate that Python 2.6 accounts for ~2% of their downloads.
pypa/pip#4343
For projects that still use Python 2.6, they can continue to pip install
an older version.
I've tried my best to remove as much 2.6 specific code as I can,
including the 'Programming Language :: Python :: 2.6' trove classifier
from setup.py. I've also removed Travis CI testing, which should result
in faster testing and fewer wasted resources.
Code changed:
Thanks for considering.