Replace special symbol characters with other characters to allow them to be drawn as mermaid #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syou6162
changed the title
syou6162
force-pushed
the
feature/replace_special_characters
branch
2 times, most recently
from
092f03e
to
6e9f129
Compare
… to be drawn as mermaid
syou6162
force-pushed
the
feature/replace_special_characters
branch
from
6e9f129
to
61d8ae1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
============================================
+ Coverage 85.68% 100.00% +14.31%
============================================
Files 31 31
Lines 915 930 +15
============================================
+ Hits 784 930 +146
+ Misses 131 0 -131 ☔ View full report in Codecov by Sentry. |
syou6162
force-pushed
the
feature/replace_special_characters
branch
from
375a82d
to
63e45bb
Compare
syou6162
commented
Feb 9, 2024
| return None | ||
|
|
||
|
|
||
| def replace_column_type(column_type: str) -> str: |
There was a problem hiding this comment.
There are many possible ways to abbreviate or omit this character, and it may be possible to change it from an environment variable or command line argument. However, we want to start out with a simple form.
datnguye
reviewed
Feb 10, 2024
|
LGTM for the code changes, thanks for your proactive contribution so far @syou6162 ❤️ I will create v1.11.0b1 right after this gets merged |
syou6162
force-pushed
the
feature/replace_special_characters
branch
2 times, most recently
from
6da2b40
to
e456855
Compare
syou6162
force-pushed
the
feature/replace_special_characters
branch
from
e456855
to
d5a402f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #81
Description
Mermaid may not be able to render special characters. To deal with such cases, we have made changes to replace or omit special characters.
Checklist