fix/field-resolve-error: fix error exception for non BackedEnum when n…

[korobkovandrey]

ErrorException when nova update-fields request for simple UnitEnum (not BackedEnum):
Undefined property: App\Enums\Status::$value

[AndreSchwarzer]

Hi, can you elaborate why in case of an UnitEnum the property value is no longer returned but name?

Do you have a code sample "before" "after" to highlight the necessity of this change?

Did you make sure it doesn't break the current behavior?

Thanks.

[korobkovandrey]

Hi, a simple UnitEnum does not value, its value is name. The current version does not support them. This change makes it possible to use them. Also, the JsonSerializable interface needs to be implemented for use in laravel.
Example:

// simple UnitEnum, instance of UnitEnum
enum Status implements \JsonSerializable
{
    use LaravelEnumHelper;

    case ENABLED;
    case DISABLED;

    // need for laravel responses
    public function jsonSerialize(): string
    {
        // this condition is not needed here, the code is for common use (in a trait)
        if($this instanceof BackedEnum){
            return $this->value;
        }
        return $this->name;
    }
}

echo Status::ENABLED->value;

//result: PHP Warning:  Undefined property: Status::$value

// in model:
    protected $casts = [
        'status' => Status::class,
    ];

My change doesn't change anything for BackedEnum.

// instance of StringBackedEnum > BackedEnum > UnitEnum
enum StatusBackedString: string
{
    use LaravelEnumHelper;

    case ENABLED = 'enabled';
    case DISABLED = 'disabled';
}

// instance of IntBackedEnum > BackedEnum > UnitEnum
enum StatusBackedInt: int
{
    use LaravelEnumHelper;

    case ENABLED = 1;
    case DISABLED = 2;
}

[sergiu-petrica]

The readme of this package states that pure enums are supported. This isn't the case as any attempt to use a pure enum results in an Undefined property: $value error as described in this PR.

You guys should either merge this PR, or update the readme so it clearly states pure enums aren't supported.

[trippo]

You are right

[trippo]

Sorry for delay