Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get private emails #4

Merged
merged 3 commits into from
Jul 4, 2017
Merged

get private emails #4

merged 3 commits into from
Jul 4, 2017

Conversation

zelima
Copy link
Collaborator

@zelima zelima commented Jul 3, 2017

getting Guaranteed Emails from GitHub

* get_userUprofile under test
* small logic for getting priv emails if not there
* requests-mock for mocking http requests
refs #2
@zelima zelima requested review from akariv and anuveyatsu July 3, 2017 11:28
Copy link
Collaborator

@akariv akariv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, other than that lgtm

@akariv
Copy link
Collaborator

akariv commented Jul 3, 2017

Also tests not passing

* break loop when found match
* fix pylama complains
@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 72.119% when pulling 6ef66e7 on fix/get-private-emails into febed75 on master.

@zelima
Copy link
Collaborator Author

zelima commented Jul 4, 2017

@akariv fixed the tests and break is there. Can we merge with tests as are?

@akariv akariv merged commit 067cab9 into master Jul 4, 2017
@akariv akariv deleted the fix/get-private-emails branch July 4, 2017 10:57
@zelima zelima mentioned this pull request Jul 10, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants