Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial: "How to theme your Flowershow website with fonts/colors" #292

Closed
5 of 7 tasks
olayway opened this issue Nov 18, 2022 · 9 comments · Fixed by #391
Closed
5 of 7 tasks

Tutorial: "How to theme your Flowershow website with fonts/colors" #292

olayway opened this issue Nov 18, 2022 · 9 comments · Fixed by #391
Assignees
Labels
enhancement New feature or request Stream: App App itself i.e. functionality of template

Comments

@olayway
Copy link
Member

olayway commented Nov 18, 2022

Quick tutorial / howto on modifying your theme using tailwind.config.js

Note: this involves them messing with the .flowershow folder so flag that ...

Job Stories

When i want to theme my site i want to change the default font (i.e. used for navbar, footer, main text) so that ...

When i want to theme my site i want to change the font for headings (and not rest of stuff)

[Low] When i want to them my site i want to use a custom font for just a single section so that ...

Colors

Want to customize

  • background color (in dark and light mode)
  • text color (in dark and light mode)
  • ...?

Acceptance

Tutorial doc page on:

Tasks

  • tutorial on how to add custom colors
  • tutorial on how to add custom fonts
  • Add a commit changing the font for whole site (in a nice way) using a google font only pushing this after font/color fixes has been made in core
  • Add a commit changing the key colors (e.g. font, background) only pushing this after font/color fixes has been made in core
  • update tutorial as per detailed comments in PR Tutorial: Customize your site's fonts and colors #345

Notes

  • Could go into more detail on how to apply these to the whole website instead of just specific pages eg. where you would add these classes in layout/docs
@olayway olayway changed the title (LifeItself and Datopian) theming? Tutorial: "How to theme your Flowershow website" Nov 18, 2022
@rufuspollock
Copy link
Member

@khalilcodes can you share your notes (hackmd i think?) here from work done on life itself.

@rufuspollock rufuspollock changed the title Tutorial: "How to theme your Flowershow website" Tutorial: "How to theme your Flowershow website with fonts/colors" Nov 22, 2022
@rufuspollock
Copy link
Member

@khalilcodes are these the notes you have? https://hackmd.io/_YoAblOjTPSnVq9hEuYUIg

@khalilcodes
Copy link
Contributor

@rufuspollock yes. @PhilippeduPreez 👆 some docs on customization.

@olayway olayway added enhancement New feature or request Stream: App App itself i.e. functionality of template labels Dec 6, 2022
@PhilippeduPreez
Copy link
Contributor

PhilippeduPreez commented Dec 6, 2022

Updated theme customization https://hackmd.io/6GfGr0TBQBuslEgYVOYviQ

@PhilippeduPreez
Copy link
Contributor

@rufuspollock @khalilcodes I'm not sure exactly how we want the navbar, footer to be more customizable? Is it only the colors/fonts/background or anything more to do with how its laid out? Also something like the background of the site should probably be using a global var, so a user does not have to make changes at multiples places if they want a background change?

@rufuspollock
Copy link
Member

@PhilippeduPreez ignore navbar - i've removed from acceptance. BTw if you are working on an issue i'd imagine a tasks section in description (even if a bit trivial!) - shows you have thought about plan of work b4 starting a bit! 😄

@PhilippeduPreez
Copy link
Contributor

@khalilcodes @rufuspollock I think we need still need to add some custom css to flowershow core make the colors work properly for theming.

Currently this is display in custom dark mode:

image

The nav might be missing the dark:background-dark class, and I assume we want the headings to be the same color as the paragraphs?

And custom light mode:

image

@PhilippeduPreez PhilippeduPreez linked a pull request Jan 23, 2023 that will close this issue
@rufuspollock
Copy link
Member

@PhilippeduPreez can you confirm @khalilcodes has seen this and we action it asap so we can unblock resolving this.

@khalilcodes
Copy link
Contributor

@rufuspollock I and @PhilippeduPreez discussed this in the call today.

olayway pushed a commit that referenced this issue Oct 31, 2023
olayway pushed a commit that referenced this issue Oct 31, 2023
nyejon pushed a commit to nyejon/flowershow_blog that referenced this issue Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stream: App App itself i.e. functionality of template
Projects
None yet
4 participants