Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordpress to (flowershow) markdown v0.2 #346

Closed
16 of 17 tasks
rufuspollock opened this issue Dec 7, 2022 · 1 comment
Closed
16 of 17 tasks

Wordpress to (flowershow) markdown v0.2 #346

rufuspollock opened this issue Dec 7, 2022 · 1 comment
Assignees

Comments

@rufuspollock
Copy link
Member

rufuspollock commented Dec 7, 2022

Continue our work from #258. Main aim is decent tests (which also document how it works) plus improved tutorial.

Acceptance

  • reasonably thorough set of tests for conversion with fixture data
    • Fixture data
    • Tests for blog post including frontmatter
    • Tests for page including frontmatter
  • Check: does our blog feature do SEO and especially set the image from the image attribute if present

Tasks

More testing

  • Get some fixture data (that we can evolve in future) @philippe

    • Set up a free wordpress site e.g. on wordpress.com ✅2022-12-07 https://wptomarkdowntest.wordpress.com
    • Create 1/2 pages
    • Create 1/2 blog posts
    • With some images
    • Upload a PDF file somewhere and link from a post/page
    • Export
  • Tests @philippe / @khalilcodes ✅ 2022-12-08

    • Posts
    • Pages
    • Assets (?)
    • (maybe) some of options to the conversion script
    Screen Shot 2022-12-08 at 8 10 06 PM

Notes

Questions

  • What happens to categories? ✅2022-12-07 they get outputted to the categories front matter
    • What happens to category info itself e.g. its full name (vs its slug)
  • What happens to tags? ✅2022-12-07 they get outputted to tags field
  • What happens to featured image? ✅2022-12-07 this is set in image property of frontmatter
  • What happens to other metadata? e.g. do we have an option to keep all wordpress metadata in frontmatter (perhaps prefixed with wp_ or similar?)
@rufuspollock
Copy link
Member Author

FIXED. We have improved the script and its tests.

rufuspollock added a commit to rufuspollock/flowershow that referenced this issue Oct 27, 2023
olayway pushed a commit that referenced this issue Oct 31, 2023
olayway pushed a commit that referenced this issue Oct 31, 2023
olayway pushed a commit that referenced this issue Oct 31, 2023
olayway pushed a commit that referenced this issue Oct 31, 2023
nyejon pushed a commit to nyejon/flowershow_blog that referenced this issue Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants