Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transclusions/Note embeddings cause hydration errors #545

Closed
Mr-Pine opened this issue Aug 9, 2023 · 3 comments · Fixed by #554
Closed

Transclusions/Note embeddings cause hydration errors #545

Mr-Pine opened this issue Aug 9, 2023 · 3 comments · Fixed by #554
Assignees
Labels
bug Something isn't working Stream: App App itself i.e. functionality of template

Comments

@Mr-Pine
Copy link

Mr-Pine commented Aug 9, 2023

Currently, if a markdown file contains an Obsidian-style transclusion like ![[my-other-note.md]] you get an error in dev mode

Error message

image

and nothing happens in export mode.

I understand that that is a pretty big feature, but I have found very litte (up to date) information on whether and when support for transclusions is planned.

In the meantime, it might make sense to transform transclusions into normal links, so that not all functionality is lost and the site is not unusable in dev mode

@olayway
Copy link
Member

olayway commented Aug 10, 2023

@Mr-Pine thank you for submitting the issue! I totally agree, Obsidian note embeds shouldn't throw an error and at least temporarily should be converted to links. I'll take care of it!

@olayway olayway self-assigned this Aug 10, 2023
@olayway olayway added the bug Something isn't working label Aug 10, 2023
@olayway olayway changed the title Transclusions/Note embedding Transclusions/Note embeddings cause hydration errors Aug 10, 2023
@olayway olayway added the Stream: App App itself i.e. functionality of template label Aug 10, 2023
@olayway
Copy link
Member

olayway commented Aug 14, 2023

@Mr-Pine This has just been fixed. Thanks again for reporting this issue! 🌷

@Mr-Pine
Copy link
Author

Mr-Pine commented Aug 14, 2023

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stream: App App itself i.e. functionality of template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants