Agrego tests de themes y keywords

datosgobar · Aug 3, 2018 · 3656fed · 3656fed
1 parent 14f71db
commit 3656fed
Show file tree

Hide file tree

Showing 2 changed files with 151 additions and 0 deletions.
diff --git a/tests/samples/invalid_themes_and_keywords.json b/tests/samples/invalid_themes_and_keywords.json
@@ -0,0 +1,135 @@
+{
+    "publisher": {
+        "mbox": "datos@modernizacion.gob.ar",
+        "name": "Ministerio de Modernización"
+    },
+    "description": "Datasets para reporte pre cosecha",
+    "title": "Cosechando Datos Argentina",
+    "issued": "2016-04-14T19:48:05.433640-03:00",
+    "superThemeTaxonomy": "http://datos.gob.ar/superThemeTaxonomy.json",
+    "dataset": [
+        {
+            "identifier": "1",
+            "publisher": {
+                "name": "aName"
+            },
+            "description": "Datos correspondientes al Sistema de Contrataciones Electrónicas (Argentina Compra)",
+            "superTheme": [
+                "ECON",
+                "HEAL"
+            ],
+            "theme": [
+                "contrataciones!",
+                "compras&",
+                "convocatorias@"
+            ],
+            "keyword": [
+                "guion-punto.gbajo_",
+                "num3r05",
+                "MaYuScUlAs"
+            ],
+            "title": "Sistema de contrataciones electrónicas UNO",
+            "issued": "2016-04-14T19:48:05.433640-03:00",
+            "modified": "2016-04-14T19:48:05.433640-03:00",
+            "source": "Ministerio de modernizacion",
+            "accrualPeriodicity": "R/P1W",
+            "distribution": [
+                {
+                    "accessURL": "http://datos.gob.ar",
+                    "downloadURL": "http://datos.gob.ar/dataset1.csv",
+                    "issued": "2016-04-14T19:48:05.433640-03:00",
+                    "title": "Convocatorias 2015"
+                },
+                {
+                    "accessURL": "http://datos.gob.ar",
+                    "downloadURL": "http://186.33.211.253/dataset2.csv",
+                    "title": "Convocatorias 2016",
+                    "issued": "2016-04-14T19:48:05.433640-03:00"
+                },
+                {
+                    "accessURL": "http://datos.gob.ar",
+                    "downloadURL": "http://186.33.211.253/dataset3.csv",
+                    "title": "Convocatorias 2017",
+                    "issued": "2016-04-14T19:48:05.433640-03:00"
+                },
+                {
+                    "accessURL": "http://datos.gob.ar",
+                    "downloadURL": "http://186.33.211.253/dataset4.csv",
+                    "title": "Convocatorias abiertas durante el año 2015",
+                    "issued": "2016-04-14T19:48:05.433640-03:00",
+                    "format": "XLSX"
+                }
+            ]
+        },
+        {
+            "identifier": "2",
+            "publisher": {
+                "name": "Ministerio de Modernización. Secretaría de Modernización Administrativa. Oficina Nacional de Contrataciones"
+            },
+            "description": "Datos correspondientes al Sistema de Contrataciones Electrónicas (Argentina Compra)",
+            "superTheme": [
+                "ECON"
+            ],
+            "theme": [
+                "guion-punto.gbajo_",
+                "num3r05",
+                "MaYuScUlAs"
+            ],
+            "keyword": [
+                ";;bienes;;",
+                "::compras::",
+                "//contrataciones//"
+            ],
+            "title": "Sistema de contrataciones electrónicas DOS",
+            "issued": "2016-04-14T19:48:05.433640-03:00",
+            "modified": "2016-04-14T19:48:05.433640-03:00",
+            "source": "Ministerio de modernizacion",
+            "accrualPeriodicity": "eventual",
+            "distribution": [
+                {
+                    "accessURL": "http://datos.gob.ar/dataset/sistema-de-contrataciones-electronicas-argentina-compra/archivo/fa3603b3-0af7-43cc-9da9-90a512217d8a",
+                    "downloadURL": "http://186.33.211.253/dataset/99db6631-d1c9-470b-a73e-c62daa32c420/resource/4b7447cb-31ff-4352-96c3-589d212e1cc9/download/convocatorias-abiertas-anio-2015.csv",
+                    "title": "Convocatorias abiertas durante el año 2015",
+                    "issued": "2016-04-14T19:48:05.433640-03:00",
+                    "format": "PDF"
+                }
+            ]
+        },
+        {
+            "identifier": "3",
+            "publisher": {
+                "name": "Ministerio de Modernización. Secretaría de Modernización Administrativa. Oficina Nacional de Contrataciones"
+            },
+            "description": "Datos correspondientes al Sistema de Contrataciones Electrónicas (Argentina Compra)",
+            "superTheme": [
+                "ECON"
+            ],
+            "theme": [
+                "contrataciones",
+                "compras",
+                "convocatorias"
+            ],
+            "keyword": [
+                "bienes",
+                "compras",
+                "contrataciones"
+            ],
+            "title": "Sistema de contrataciones electrónicas TRES",
+            "issued": "2016-04-14T19:48:05.433640-03:00",
+            "modified": "2016-04-14T19:48:05.433640-03:00",
+            "source": "Ministerio de modernizacion",
+            "accrualPeriodicity": "R/P1M",
+            "distribution": [
+                {
+                    "accessURL": "http://datos.gob.ar/dataset/sistema-de-contrataciones-electronicas-argentina-compra/archivo/fa3603b3-0af7-43cc-9da9-90a512217d8a",
+                    "downloadURL": "http://186.33.211.253/dataset/99db6631-d1c9-470b-a73e-c62daa32c420/resource/4b7447cb-31ff-4352-96c3-589d212e1cc9/download/convocatorias-abiertas-anio-2015.csv",
+                    "title": "Convocatorias abiertas durante el año 2015",
+                    "issued": "2016-04-14T19:48:05.433640-03:00",
+                    "format": "CSV"
+                }
+            ]
+        }
+    ],
+    "version": "1.1",
+    "identifier": "7d4d816f-3a40-476e-ab71-d48a3f0eb3c8"
+}
diff --git a/tests/test_validation.py b/tests/test_validation.py
@@ -108,6 +108,22 @@ def test_invalid_empty_super_theme_list(self):
         regex = "\[\] is too short"
         self.validate_message_with_file(case_filename, expected_valid, path, regex)
 
+    def test_invalid_themes(self):
+        case_filename = "invalid_themes_and_keywords"
+        expected_valid = False
+        path = ['error', 'dataset', 0, 'errors', 0, 'message']
+        regex = "\[%s, %s, %s\] is not valid under any of the given schemas"\
+                % (jsonschema_str('contrataciones!'), jsonschema_str('compras&'), jsonschema_str('(convocatorias@)'))
+        self.validate_message_with_file(case_filename, expected_valid, path, regex)
+
+    def test_invalid_keywords(self):
+        case_filename = "invalid_themes_and_keywords"
+        expected_valid = False
+        path = ['error', 'dataset', 1, 'errors', 0, 'message']
+        regex = "\[%s, %s, %s\] is not valid under any of the given schemas"\
+                % (jsonschema_str(';;bienes;;'), jsonschema_str('::compras::'), jsonschema_str('//contrataciones//'))
+        self.validate_message_with_file(case_filename, expected_valid, path, regex)
+
     def test_several_assorted_errors(self):
         case_filename = "several_assorted_errors"
         expected_errors = [