Remuevo validación de URLs repetidas en un catálogo: hay casos genuin…

…os de documentación de una misma URL en distintos datasets.
datosgobar · Dec 28, 2018 · 7ce25c2 · 7ce25c2
1 parent 8c616f9
commit 7ce25c2
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 11 deletions.
diff --git a/pydatajson/__init__.py b/pydatajson/__init__.py
@@ -13,7 +13,7 @@
 
 __author__ = """Datos Argentina"""
 __email__ = 'datos@modernizacion.gob.ar'
-__version__ = '0.4.29'
+__version__ = '0.4.30'
 
 """
 Logger base para librería pydatajson

diff --git a/pydatajson/validation.py b/pydatajson/validation.py
@@ -301,14 +301,14 @@ def iter_custom_errors(catalog):
 
         # chequea que no haya duplicados en los downloadURL de las
         # distribuciones
-        urls = []
-        for dataset in catalog["dataset"]:
-            urls += [distribution['downloadURL']
-                     for distribution in dataset['distribution']
-                     if distribution.get('downloadURL')]
-        dups = _find_dups(urls)
-        if len(dups) > 0:
-            yield ce.DownloadURLRepetitionError(dups)
+        # urls = []
+        # for dataset in catalog["dataset"]:
+        #     urls += [distribution['downloadURL']
+        #              for distribution in dataset['distribution']
+        #              if distribution.get('downloadURL')]
+        # dups = _find_dups(urls)
+        # if len(dups) > 0:
+        #     yield ce.DownloadURLRepetitionError(dups)
 
         # chequea que las URLs de las distribuciones estén operativas
         # hay que revisar

diff --git a/requirements_dev.txt b/requirements_dev.txt
@@ -15,3 +15,4 @@ mock==2.0.0;python_version<"3.4"
 pycallgraph
 setuptools>=38.6
 wheel>=0.31
+vcrpy
diff --git a/setup.py b/setup.py
@@ -21,7 +21,7 @@
 
 setup(
     name='pydatajson',
-    version='0.4.29',
+    version='0.4.30',
     description="Paquete en python con herramientas para generar y validar metadatos de catálogos de datos en formato data.json.",
     long_description=readme + '\n\n' + history,
     long_description_content_type='text/markdown',

diff --git a/tests/support/factories/core_files.py b/tests/support/factories/core_files.py
@@ -101,7 +101,7 @@
     'invalid_catalog_publisher_type': invalid_catalog_publisher_type(),
     'invalid_publisher_mbox_format': invalid_publisher_mbox_format(),
 
-    'repeated_downloadURL': repeated_downloadURL(),
+    # 'repeated_downloadURL': repeated_downloadURL(),
 }
 
 TEST_FILE_RESPONSES = {}