202 restore multiples organizaciones #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pydatajson/ckan_utils.py
Outdated
| for theme in themes | ||
| ] | ||
|
|
||
| package['groups'] = package.get('groups', []) |
There was a problem hiding this comment.
Esto se logra mejor con package.setdefault('groups', [])
| - **apikey**: La apikey de un usuario con los permisos que le permitan crear o actualizar el dataset. | ||
| - **dataset_list**: Los ids de los datasets a restaurar. Si no se pasa una lista, todos los datasests se restauran. | ||
| - **owner_org**: La organización a la cual pertencen los datasets. | ||
| - **download_strategy**: Una función (catálogo, distribución)->bool. Sobre las distribuciones que evalúa True, |
There was a problem hiding this comment.
Cambio brusco: no podríamos pasar las ids de distribuciones a subir directamente? Simplificaría la firma de la función
docs/MANUAL.md
Outdated
| parámetro. Toma los siguientes parámetros: | ||
| - **catalog**: El catálogo de origen que se restaura. | ||
| - **portal_url**: La URL del portal CKAN de destino. | ||
| - **apikey**: La apikey de un usuario con los permisos que le permitan crear o actualizar el dataset. |
There was a problem hiding this comment.
"el dataset" -> los datasets
pydatajson/federation.py
Outdated
| """ | ||
| push_new_themes(catalog, portal_url, apikey) | ||
| if dataset_list is None: | ||
| dataset_list = [ds['identifier'] for ds in catalog.datasets] |
pydatajson/federation.py
Outdated
| org_list = origin_portal.action.organization_list() | ||
| except CKANAPIError as e: | ||
| logger.exception( | ||
| 'Ocurrió un buscando las organizaciones del portal {}: {}' |
There was a problem hiding this comment.
"ocurrió un buscando", falta la palabra "error", asumo
| file_name = dist.get('fileName') or \ | ||
| dist['downloadURL'].split('/')[-1] | ||
| os.rename(tmpfile.name, os.path.join(tmpdir, file_name)) | ||
| tmpfile.name = os.path.join(tmpdir, file_name) |
There was a problem hiding this comment.
Por qué todo el barullo de tempfile? Podés usar context managers para borrar el archivo en caso de un error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore_catalog_to_ckan()pasan a ser derestore_organization.restore_catalogse compone de varias llamadas arestore_organization