Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

125 xlsx writer bugfix #250

Merged
merged 2 commits into from
Apr 9, 2019
Merged

125 xlsx writer bugfix #250

merged 2 commits into from
Apr 9, 2019

Conversation

lrromero
Copy link
Contributor

@lrromero lrromero commented Apr 9, 2019

Closes datosgobar/django-datajsonar#125

  • Defaultea a lista vacía si no hay themes en el dataset (similar al caso de fields y distribuciones)
  • Agrega caso de test de catálogo sin themes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 82.658% when pulling 07b590d on 125-xlsx-writer-bugfix into b1a2294 on master.

@lrromero lrromero merged commit b747ab4 into master Apr 9, 2019
@lrromero lrromero deleted the 125-xlsx-writer-bugfix branch April 9, 2019 17:27
@abenassi abenassi added this to Done (dev) in datosgobar/monitoreo-apertura May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrosobko alejandrosobko alejandrosobko approved these changes

@lucaslavandeira lucaslavandeira lucaslavandeira approved these changes

@chdigiorno chdigiorno chdigiorno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
datosgobar/monitoreo-apertura
  
Done (dev)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lrromero @coveralls @alejandrosobko @lucaslavandeira @chdigiorno