Agrego parámetro validator_class #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permite extender la funcionalidad de validación de catálogos. La clase deberá implementar los métodos is_valid, que devuelve True o False según el catálogo sea válido, e iter_errors, un generator de errores. La forma más sencilla de cumplir los requerimientos es que el validador sea una instancia de jsonschema.Draft4Validator, o de una clase que herede de ésta.
1 similar comment
lrromero
approved these changes
May 24, 2019
chdigiorno
approved these changes
May 24, 2019
alejandrosobko
approved these changes
May 24, 2019
| @@ -337,3 +343,14 @@ def test_invalid_catalog_list_format(self): | |||
| error['message'] in [ | |||
| reported['dataset_error_message'] for reported | |||
| in report_list['dataset']]) | |||
|
|
|||
| def test_specify_validator_class(self): | |||
| class MyValidator(Draft4Validator): | |||
There was a problem hiding this comment.
Por qué es una clase creada dentro de un método? No es mejor tenerla afuera y poder llamarla?
| @@ -51,7 +51,8 @@ class DataJson(dict): | |||
| CATALOG_FIELDS_PATH = os.path.join(ABSOLUTE_PROJECT_DIR, "fields") | |||
|
|
|||
| def __init__(self, catalog=None, schema_filename=None, schema_dir=None, | |||
| default_values=None, catalog_format=None): | |||
| default_values=None, catalog_format=None, | |||
There was a problem hiding this comment.
Con tantos parámetros que encima pueden ser None se hace extensa la creación del objeto. Estaría bueno tener un objeto que los encapsule, construirlo con lo necesario (no necesariamente recibe todos al parecer) y pasarselo. De esta forma seguro hasta se pueda delegar lógica.
|
Cerrado, seguido en otro PR con cambios diferentes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permite extender la funcionalidad de validación de catálogos. La clase
deberá implementar los métodos is_valid, que devuelve True o False según
el catálogo sea válido, e iter_errors, un generator de errores. La forma
más sencilla de cumplir los requerimientos es que el validador sea una
instancia de jsonschema.Draft4Validator, o de una clase que herede de
ésta.