Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

273 frecuencias formatos uppercase #278

Merged
merged 8 commits into from Sep 16, 2019
Merged

273 frecuencias formatos uppercase #278

merged 8 commits into from Sep 16, 2019

Conversation

FScaccheri
Copy link
Contributor

  • Agrego una validacion en la creacion del campo de frecuencia de un dataset, para mantener solamente el campo 'EVENTUAL' en mayusculas
  • Agrego helper que convierte los fields de un diccionario a uppercase, y lo uso para convertir los formatos del indicador a mayusculas

Closes #273

@coveralls
Copy link

coveralls commented Sep 13, 2019 •
edited

Coverage Status

Coverage decreased (-0.06%) to 83.107% when pulling 96fd5be on 273-frecuencias-formatos-uppercase into b17d9ca on master.

@lucaslavandeira
Copy link
Contributor

@lrromero Hay algún otro metadato que no sea format que sea afectado por esta discrepancia de uppercase/lowercase?

lucaslavandeira
lucaslavandeira reviewed Sep 13, 2019
View reviewed changes
pydatajson/indicators.py Outdated
@@ -389,10 +391,10 @@ def _generate_date_indicators(catalog, tolerance=0.2, only_numeric=False):
if not periodicity:
continue
# Si la periodicity es eventual, se considera como actualizado
if periodicity == 'eventual':
if periodicity in ('eventual', 'EVENTUAL'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto podría ser un método privado, solo por legibilidad. if eventual_periodicity(periodicity): ...

@FScaccheri FScaccheri merged commit 26abc77 into master Sep 16, 2019
@AWolfsdorf AWolfsdorf deleted the 273-frecuencias-formatos-uppercase branch September 23, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaslavandeira lucaslavandeira lucaslavandeira left review comments

@lrromero lrromero lrromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@FScaccheri @coveralls @lucaslavandeira @lrromero