282 validar borken url paralelizando #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 7, 2019 11:59
…osgobar/pydatajson into 282-validar-borken-url-paralelizando
|
Revisar tiempos de ejecución de los tests, algún tema de threading demora la salida del programa por unos 40-60 segundos |
FScaccheri
approved these changes
Oct 7, 2019
FScaccheri
approved these changes
Oct 8, 2019
lucaslavandeira
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se agrego una clase threading_helper la que enviandole una funcion, cantindad de threads y una lista de datos, hace un mapeo de la lista con sus correspondientes salidas si el dato i-esimo se usara en la funcion.
Este procedimiento no funciona con los comportamientos de Cassette ya que el mismo consume recursos fisicos y no es compatible con la concurrencia, para eso, en los tests que usan esta funcion se monkeypatchea la constante CANT_THREADS_BROKEN_URL_VALIDATOR en 1 para que no genere errores.
closes #282