-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] rofi does not build with meson 0.55 #1159
Comments
Did the reporter do a recursive checkout of rofi? (e.g. pull in the submodules).
or if you want to do it after a checkout
|
I get same warning, but it does work.
edit, aah see now that it used to work but not anymore. (and recursive checkout was done). |
Yes that's confusing because it shows the same error as when submodules are missing. I've checked it works on 0.53.2 and 0.54 but not 0.55. |
Make xcb a non-nested subproject (via simlink). Issue: #1159
made a quick 'n dirty work around. not sure if it is sane . can this be tested? (mesonfix) |
Now meson throws
when asked to generate coverage. |
Anybody can help with this? or atleast check the branch? |
The fix works for regular builds without coverage. As you mentioned on irc, this looks like the bug mesonbuild/meson#7437, which appears on 0.55 Until meson 0.56 is out, one solution would be to pin the version on 0.54, I can open a PR. |
Ah actually, meson released 0.55.1 with the fix three days ago. The branch should be good as is, it can be checked by re-running Travis on it. |
https://travis-ci.org/github/davatorium/rofi/jobs/718893107 seems to be still failing on main branch. |
They fixed mesonbuild/meson#7437 which breaks coverage builds in 0.55.1 but not the issue reported here (which will probably stay IMO), so we still need some change like the one in https://github.com/davatorium/rofi/tree/mesonfix. |
Ok. I need to check if that fix does not break make dist. |
https://travis-ci.org/github/davatorium/rofi/builds/718918497 seems to fix it (merged mesonfix) |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Initially reported here lbonn#2. This is not specific to the fork and also happens when building latest rofi with meson 0.55.
It looks like having subprojects with slash in their name does not work at all now. The easiest dirty fix I've found is to just mess with some symlinks in
subprojects
?Version
Output of
rofi -v
57ee693 (current tip of next branch)
Steps to reproduce
What behaviour you see
What behaviour you expect to see
It builds.
The text was updated successfully, but these errors were encountered: