Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for new device #10

Closed
wants to merge 3 commits into from
Closed

Conversation

rondoval
Copy link

This is adding support for no-name BLE RGB Christmas lights. The differences are:

  • different UUIDs
  • different turn on command

* add UUIDs for my LEDs

* turn on fix

* bugfix

* add manual mac

* fix brightness

* fix for device not ready

* restore original characteristic

* bugfixes

* add color modes
@@ -165,7 +168,7 @@ def effect(self):

@retry_bluetooth_connection_error
async def set_white(self, intensity: int):
await self._write([0x7e, 0x00, 0x01, intensity, 0x00, 0x00, 0x00, 0x00, 0xef])
await self._write([0x7e, 0x00, 0x01, int(intensity*100/255), 0x00, 0x00, 0x00, 0x00, 0xef])
Copy link
Author

@rondoval rondoval Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if this is true for other devices... my one seems to have a range of 0 - 0x64; i.e. 0x64 is max brightness, 0x65 is same as 0x0.

This command is also setting brightness in RGB mode - also no idea how it works with the originally supported devices.

@dave-code-ruiz
Copy link
Owner

Please, can you use led ble integration? (https://www.home-assistant.io/integrations/led_ble/)
I think this integration is best for you, report me if it work for you
Thanks

dave-code-ruiz added a commit that referenced this pull request Dec 28, 2022
- Support for new devices in #10 and #11
- Configure reset white for #12
@dave-code-ruiz
Copy link
Owner

dave-code-ruiz commented Dec 28, 2022

Please, if you have time, test my commit changes in version 1.0.1

I create merge with your PR and other strip support

Thanks

@rondoval
Copy link
Author

rondoval commented Jan 4, 2023

@dave-code-ruiz 1.0.1 works fine with my strips, thank you.
Regarding led_ble integration - it doesn't support these.

@dave-code-ruiz
Copy link
Owner

@dave-code-ruiz 1.0.1 works fine with my strips, thank you. Regarding led_ble integration - it doesn't support these.

Great news !! I close PR if you have problems open New issue, thanks for your support

@rondoval rondoval deleted the pr_1 branch January 5, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants