WebSocket.send_bytes is a coroutine as of aiohttp 3.0 changing transp… #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebshow
reviewed
Mar 20, 2018
| async def write(self, message): | ||
| corou = self._ws.send_bytes(message) | ||
| if asyncio.iscoroutine(corou): | ||
| await corou | ||
|
|
There was a problem hiding this comment.
Could we use coro instead of corou? No big deal really
|
Other than my small inline comment this is LGTM Please update and I will merge. Thanks @xzy3 ! |
|
@davebshow Ok I rebased in the variable name change as requested. |
…ort.write to await the coroutine if necessary.
|
A follow up: looking through the history of aiohttp it looks like the |
|
This issue is a blocker. The most basic tutorial in the documentation does not work until this fix goes live. Can we have a new release? I'm open to suggestions regarding workarounds if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ort.write to await the coroutine if necessary.
Fixes #15