Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pull duplicative code to parent class #2

Merged
merged 5 commits into from
Apr 28, 2022
Merged

refactor: pull duplicative code to parent class #2

merged 5 commits into from
Apr 28, 2022

Conversation

davenix-palmetto
Copy link
Owner

WIP

@davenix-palmetto
Copy link
Owner Author

davenix-palmetto commented Apr 28, 2022 •
edited
Loading

@davenix-palmetto I believe the issue is that you're trying to set/attach this secret variable before clusterIdentifier is set in the child classes to cluster.ref. Ideally you'd move the new CfnDBCluster call here so that cluster.ref is available, but the child classes differ is the options passed to new CfnDBCluster. So while it's still a bit WET I think you should move this line back to both child classes after the clusterIdentifier is set.

@volleio passing now 😄

@davenix-palmetto davenix-palmetto marked this pull request as ready for review April 28, 2022 03:20
@davenix-palmetto davenix-palmetto merged commit ca54a07 into feat(rds)/add-secret-rotation-to-cluster-from-snapshot Apr 28, 2022
@davenix-palmetto davenix-palmetto deleted the trying-to-refactor branch April 28, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davenix-palmetto @volleio