Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any support for ssl & ssl certs? #28

Closed
chaodoze opened this issue Apr 16, 2019 · 5 comments
Closed

Any support for ssl & ssl certs? #28

chaodoze opened this issue Apr 16, 2019 · 5 comments
Assignees
Labels
feature good first issue Good for newcomers question Further information is requested
Milestone

Comments

@chaodoze
Copy link

or plans to support?

@davesag davesag added the question Further information is requested label Apr 18, 2019
@davesag
Copy link
Owner

davesag commented Apr 18, 2019

@chaodoze would you mind spelling out in more detail what you want?

@davesag
Copy link
Owner

davesag commented Apr 19, 2019

I'm looking at sequelize/sequelize#956 but that's quite an old issue. I am using this library in production on projects running on Heroku without any special config on my end, though I do recall some config needed to be done at the Heroku end.

Anyway please get back to me with more details and I am happy to look into this further for you.

@chaodoze
Copy link
Author

chaodoze commented Apr 19, 2019 via email

@davesag
Copy link
Owner

davesag commented Apr 20, 2019

Hi @chaodoze that's interesting. Under the hood I am using pgtools to handle the creation of the database, but am simply using sequelize to actually connect to it once the database has been created. My library just formats the config correctly for either to use.

Assuming your database is running in production when secured you probably won't need to use the makeInitialiser feature I provide (which is the bit that uses pgtools) but you will need to pass ssl configuration options through to sequelize. (Note if you are not using sequelize then you don't need this library at all).

It looks like I could just take the ssl block from config and pass it through as dialectOptions. I'd be willing to try that as a test-release and you could check to see if that does what you need. If it does then I'd also probably have to refactor the makeInitialiser function to not use pgtools.

So one step at a time perhaps.

I'm also on vacation right now (we Australians get a 4 day break for easter) but I am not doing much other than loll about by the hotel pool, so will spend a bit more time having a look at this.

@davesag davesag added feature good first issue Good for newcomers work in progress Someone is doing something about it labels Apr 20, 2019
@davesag davesag added this to the Version 1.2 milestone Apr 20, 2019
davesag added a commit that referenced this issue Apr 20, 2019
@davesag davesag self-assigned this Apr 20, 2019
davesag added a commit that referenced this issue Apr 21, 2019
@davesag davesag removed the work in progress Someone is doing something about it label Apr 21, 2019
@davesag
Copy link
Owner

davesag commented Apr 21, 2019

Hi @chaodoze This feature is now available in version 1.2.0 — thanks for your suggestion.

@davesag davesag closed this as completed Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants