Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on pgtools #30

Closed
davesag opened this issue Apr 20, 2019 · 1 comment · Fixed by #85
Closed

Remove dependency on pgtools #30

davesag opened this issue Apr 20, 2019 · 1 comment · Fixed by #85
Assignees
@davesag
Labels
documentation feature security Involves a security problem work in progress Someone is doing something about it
Milestone
Version 2.0.0

Comments

@davesag
Copy link
Owner

davesag commented Apr 20, 2019

If I support ssl config I'll need to refactor my code to not use pgtools as it doesn't support the ssl options.

Ref #28
@davesag davesag modified the milestones: Version 1.2, Version 1.2.1 Apr 20, 2019
@davesag davesag modified the milestones: Version 1.2.1, Version 1.2.2 May 4, 2019
@davesag davesag modified the milestones: Version 1.2.2, Version 2.0.0 Feb 7, 2020
@davesag
Copy link
Owner Author

davesag commented Jun 22, 2020

This is now a bit more urgent due to

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ yargs-parser                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=13.1.2 <14.0.0 || >=15.0.1 <16.0.0 || >=18.1.2             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ pgtools                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ pgtools > yargs > yargs-parser                               │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1500                            │
└───────────────┴──────────────────────────────────────────────────────────────┘

@davesag davesag added the security Involves a security problem label Jun 22, 2020
@davesag davesag self-assigned this Jul 21, 2020
@davesag davesag added the work in progress Someone is doing something about it label Jul 21, 2020
davesag added a commit that referenced this issue Jul 21, 2020
@davesag
#30 remove pgtools and use pg directly to create a db if needed
7aac713
davesag added a commit that referenced this issue Jul 21, 2020
@davesag
#30 removed reference to pgtools and inserted reference to pg as a pe…
24066c0 
…er dependency
@davesag davesag mentioned this issue Jul 21, 2020
Merged
davesag added a commit that referenced this issue Jul 21, 2020
@davesag
Merge pull request #85 from davesag/feature/30/replace-pgtools
6ebad10 
[feature, #30] replace pgtools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davesag davesag

Labels
documentation feature security Involves a security problem work in progress Someone is doing something about it
Projects
None yet
Milestone
Version 2.0.0
Development

Successfully merging a pull request may close this issue.

[feature, #30] replace pgtools davesag/sequelize-pg-utilities
1 participant
@davesag