Standardize "requires a subcommand" error message #299
Conversation
lib/gli/command_support.rb
Outdated
| raise BadCommandLine,"Command '#{name}' requires a subcommand" | ||
| end | ||
| elsif have_subcommands? | ||
| if have_subcommands? |
There was a problem hiding this comment.
I'm pretty sure that reordering these conditionals is safe but please double-check that!
There was a problem hiding this comment.
It seems to be breaking this test:
https://github.com/davetron5000/gli/blob/main/test/tc_subcommands.rb#L149
(sorry about the weird test framework—Given/When/Then don't do anything so the test is vanilla Test::Unit really)
That test is wanting to see that if the command has a subcommand, but extra args were given, the message is "Unknown command". I guess that error check has precedence, so I think this if statement does need to be kinda (annoyingly) complex.
There was a problem hiding this comment.
Ah whoops! I think I can just reorder the if and elsif parts of the conditional—let me know if that seems right now.
(I'm trying out GitHub's "make a code change and PR right from the browser" feature but a downside is I can't run tests. Let me know if this process is too annoying for you.)
|
This version passes the tests. I don't feel strongly about having a failing test that this PR fixes since it's mostly about wording and the code gets executed by the tests. Thanks! |
|
released as 2.19.2 |
|
Thank you! |
Closes #298