SonarCloud fixups (phase 2)

davewalker5 · Sep 16, 2022 · bec012d · bec012d
1 parent 2eb3075
commit bec012d
Show file tree

Hide file tree

Showing 12 changed files with 291 additions and 291 deletions.
diff --git a/src/FlightRecorder.BusinessLogic/Logic/UserManager.cs b/src/FlightRecorder.BusinessLogic/Logic/UserManager.cs
@@ -215,7 +215,7 @@ public async Task DeleteUserAsync(string userName)
         /// <param name="user"></param>
         /// <param name="userId"></param>
         [ExcludeFromCodeCoverage]
-        private void ThrowIfUserNotFound(User user, object userId)
+        private static void ThrowIfUserNotFound(User user, object userId)
         {
             if (user == null)
             {
@@ -230,7 +230,7 @@ private void ThrowIfUserNotFound(User user, object userId)
         /// <param name="user"></param>
         /// <param name="userId"></param>
         [ExcludeFromCodeCoverage]
-        private void ThrowIfUserFound(User user, object userId)
+        private static void ThrowIfUserFound(User user, object userId)
         {
             if (user != null)
             {

diff --git a/src/FlightRecorder.Data/FlightRecorderDbContextFactory.cs b/src/FlightRecorder.Data/FlightRecorderDbContextFactory.cs
@@ -35,7 +35,7 @@ public FlightRecorderDbContext CreateDbContext(string[] args)
         /// Create an in-memory context for unit testing
         /// </summary>
         /// <returns></returns>
-        public  FlightRecorderDbContext CreateInMemoryDbContext()
+        public static FlightRecorderDbContext CreateInMemoryDbContext()
         {
             var optionsBuilder = new DbContextOptionsBuilder<FlightRecorderDbContext>();
             optionsBuilder.UseInMemoryDatabase(Guid.NewGuid().ToString());

diff --git a/src/FlightRecorder.Manager/Logic/CommandParser.cs b/src/FlightRecorder.Manager/Logic/CommandParser.cs
@@ -44,7 +44,7 @@ public Operation ParseCommandLine(string[] args)
         /// </summary>
         /// <param name="op"></param>
         /// <param name="args"></param>
-        private void AssignOperationParameters(Operation op, string[] args)
+        private static void AssignOperationParameters(Operation op, string[] args)
         {
             switch (op.Type)
             {

diff --git a/src/FlightRecorder.Tests/AircraftManagerTest.cs b/src/FlightRecorder.Tests/AircraftManagerTest.cs
@@ -25,7 +25,7 @@ public class AircraftManagerTest
         [TestInitialize]
         public void TestInitialize()
         {
-            FlightRecorderDbContext context = new FlightRecorderDbContextFactory().CreateInMemoryDbContext();
+            FlightRecorderDbContext context = FlightRecorderDbContextFactory.CreateInMemoryDbContext();
             _factory = new FlightRecorderFactory(context);
             _factory.Aircraft.Add(Registration, SerialNumber, YearOfManufacture, ModelName, ManufacturerName);
         }

diff --git a/src/FlightRecorder.Tests/AirlineManagerTest.cs b/src/FlightRecorder.Tests/AirlineManagerTest.cs
@@ -19,7 +19,7 @@ public class AirlineManagerTest
         [TestInitialize]
         public void TestInitialize()
         {
-            FlightRecorderDbContext context = new FlightRecorderDbContextFactory().CreateInMemoryDbContext();
+            FlightRecorderDbContext context = FlightRecorderDbContextFactory.CreateInMemoryDbContext();
             _factory = new FlightRecorderFactory(context);
             _factory.Airlines.Add(EntityName);
         }

diff --git a/src/FlightRecorder.Tests/DataExchangeTests.cs b/src/FlightRecorder.Tests/DataExchangeTests.cs
@@ -35,7 +35,7 @@ public class DataExchangeTests
         [TestInitialize]
         public void TestInitialize()
         {
-            FlightRecorderDbContext context = new FlightRecorderDbContextFactory().CreateInMemoryDbContext();
+            FlightRecorderDbContext context = FlightRecorderDbContextFactory.CreateInMemoryDbContext();
             _factory = new FlightRecorderFactory(context);
             _sightingId = _factory.Sightings.Add(new FlattenedSighting
             {

diff --git a/src/FlightRecorder.Tests/FlightManagerTest.cs b/src/FlightRecorder.Tests/FlightManagerTest.cs
@@ -24,7 +24,7 @@ public class FlightManagerTest
         [TestInitialize]
         public void TestInitialize()
         {
-            FlightRecorderDbContext context = new FlightRecorderDbContextFactory().CreateInMemoryDbContext();
+            FlightRecorderDbContext context = FlightRecorderDbContextFactory.CreateInMemoryDbContext();
             _factory = new FlightRecorderFactory(context);
             _factory.Flights.Add(FlightNumber, Embarkation, Destination, AirlineName);
         }

diff --git a/src/FlightRecorder.Tests/LocationManagerTest.cs b/src/FlightRecorder.Tests/LocationManagerTest.cs
@@ -19,7 +19,7 @@ public class LocationManagerTest
         [TestInitialize]
         public void TestInitialize()
         {
-            FlightRecorderDbContext context = new FlightRecorderDbContextFactory().CreateInMemoryDbContext();
+            FlightRecorderDbContext context = FlightRecorderDbContextFactory.CreateInMemoryDbContext();
             _factory = new FlightRecorderFactory(context);
             _factory.Locations.Add(EntityName);
         }

diff --git a/src/FlightRecorder.Tests/ManufacturerTest.cs b/src/FlightRecorder.Tests/ManufacturerTest.cs
@@ -19,7 +19,7 @@ public class ManufacturerManagerTest
         [TestInitialize]
         public void TestInitialize()
         {
-            FlightRecorderDbContext context = new FlightRecorderDbContextFactory().CreateInMemoryDbContext();
+            FlightRecorderDbContext context = FlightRecorderDbContextFactory.CreateInMemoryDbContext();
             _factory = new FlightRecorderFactory(context);
             _factory.Manufacturers.Add(EntityName);
         }

diff --git a/src/FlightRecorder.Tests/ModelManagerTest.cs b/src/FlightRecorder.Tests/ModelManagerTest.cs
@@ -20,7 +20,7 @@ public class ModelManagerTest
         [TestInitialize]
         public void TestInitialize()
         {
-            FlightRecorderDbContext context = new FlightRecorderDbContextFactory().CreateInMemoryDbContext();
+            FlightRecorderDbContext context = FlightRecorderDbContextFactory.CreateInMemoryDbContext();
             _factory = new FlightRecorderFactory(context);
             _factory.Models.Add(ModelName, ManufacturerName);
         }